Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call stack view & debug model handle stack frame deemphasize presentation hint inconsistently #211854

Closed
OccasionalDebugger opened this issue May 2, 2024 · 0 comments · Fixed by #211855
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@OccasionalDebugger
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No - debugging requires plugins.

  • VS Code Version: 1.88.1
  • OS Version: MacOS

Steps to Reproduce:

  1. Use a debug adapter that applies a deemphasize presentation hint to the top StackFrame of a thread.
  2. Observe that VSCode still selects that frame for focus if a stop event is issued for that thread.

Although it isn't part of the DAP, code in the CallStackView envisions the possibility that a stack frame could have a presentation hint deemphasize, in which case it treats that frame the same as if its source had the presentation hint deemphasize, where that value is part of the DAP. However, in the code that selects the top stack frame of a given thread, only the source is checked for the deemphasize presentation hint, leading to the possibility that a frame that is 'deemphasized' according to the CallStackView is nevertheless selected for highlighting, and its source focused, when the debugger signals a stop on that thread.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 21, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 21, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants