Skip to content

Commit

Permalink
Address CG issues (#15807)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored Jun 28, 2024
1 parent 3fc0b53 commit bf5140a
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 112 deletions.
131 changes: 23 additions & 108 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2182,7 +2182,7 @@
"uuid": "^3.3.2",
"vscode-debugprotocol": "^1.41.0",
"vscode-languageclient": "8.0.2-next.5",
"vscode-tas-client": "^0.1.75",
"vscode-tas-client": "^0.1.84",
"ws": "^6.2.3",
"zeromq": "^6.0.0-beta.16",
"zeromqold": "npm:zeromq@^6.0.0-beta.6"
Expand Down Expand Up @@ -2359,6 +2359,9 @@
"@jupyterlab/coreutils": {
"url-parse": "$url-parse"
},
"@jupyterlab/services": {
"ws": "7.5.10"
},
"d3-color": "3.1.0"
}
}
2 changes: 1 addition & 1 deletion src/kernels/common/kernelSocketWrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

import { EventEmitter } from 'vscode';
import * as WebSocketWS from 'ws';
import type * as WebSocketWS from 'ws';
import { ClassType } from '../../platform/ioc/types';
import { logger } from '../../platform/logging';
import { IKernelSocket } from '../types';
Expand Down
2 changes: 1 addition & 1 deletion src/kernels/raw/session/rawSocket.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import type { KernelMessage } from '@jupyterlab/services';
import * as wireProtocol from '@nteract/messaging/lib/wire-protocol';
import uuid from 'uuid/v4';
import * as WebSocketWS from 'ws';
import type * as WebSocketWS from 'ws';
import type { Dealer, Subscriber } from 'zeromq';
import { logger } from '../../../platform/logging';
import { noop } from '../../../platform/common/utils/misc';
Expand Down
2 changes: 1 addition & 1 deletion src/webviews/webview-side/ipywidgets/kernel/kernel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Kernel, KernelMessage, ServerConnection } from '@jupyterlab/services';
// eslint-disable-next-line @typescript-eslint/no-restricted-imports
import { KernelConnection } from '@jupyterlab/services/lib/kernel/default';
import type { ISignal, Signal } from '@lumino/signaling';
import * as WebSocketWS from 'ws';
import type * as WebSocketWS from 'ws';
import { KernelSocketOptions } from '../../../../kernels/types';
import { Deferred, createDeferred } from '../../../../platform/common/utils/async';
import { serializeDataViews, deserializeDataViews } from '../../../../platform/common/utils/serializers';
Expand Down

0 comments on commit bf5140a

Please sign in to comment.