Skip to content

Commit

Permalink
Address codeQL issues (#15724)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored May 28, 2024
1 parent b519e0a commit 085a839
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion src/test/datascience/jupyterServer.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ export class JupyterServer {
}

function generateHashedPassword(password: string) {
const hash = crypto.createHash('sha1');
const hash = crypto.createHash('sha1'); // CodeQL [SM04514] This is used only in tests and not in production. Also this is a requirement of the Jupyter Application (out of our control).
const salt = genRandomString(16);
hash.update(password); // CodeQL [SM01511] This password is hashed as per the requirements of Jupyter Server application, it is only used in tests (to launch a password protected jupyter server) and not production.
hash.update(salt);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ After that we need to load slickgrid, and then the jQuery plugin from slickgrid
// use slickgridJQ instead of the usual $ to make it clear that we need that JQ and not
// the one currently in node-modules

// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
require('slickgrid/lib/jquery-1.11.2.min');

// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
require('slickgrid/lib/jquery.event.drag-2.3.0');

0 comments on commit 085a839

Please sign in to comment.