fix: ⬆️ resolve issue with helloworld-web-sample when running tests #1082
+1,873
−1,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
The latest version of text-web is 0.60. Let's use that... |
gnekich
force-pushed
the
fix/hello-world-web-samples
branch
from
e10252c to
5e452b7
Compare
|
@aeschli updated PR to bump version of @vscode/test-web to 0.0.60 |
aeschli
approved these changes
Sep 13, 2024
|
Thanks a lot, @gnekich! |
lszomoru
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current helloworld-web-sample extension does not work due to old version of @vscode/test-web
This simple PR resolves the issue when trying to test the sample by bumping the version to ^0.0.56.