Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpuinfo] Update cpuinfo to the latest version #42800

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

snnn
Copy link
Member

@snnn snnn commented Dec 20, 2024

Compared to the current version, the new cpuinfo version has the following changes:

  1. Now it is C only. It no longer requires a C++ compiler
  2. Added several new build options:
    • CPUINFO_LOG_TO_STDIO
    • USE_SYSTEM_LIBS
    • USE_SYSTEM_GOOGLEBENCHMARK
    • USE_SYSTEM_GOOGLETEST
  3. The new code is based on C++14 instead of C++11
  4. Added support for Windows ARM64. But it still has problems with ARM64EC. See: Update cpuinfo.h: add support for Windows ARM64EC pytorch/cpuinfo#227
  5. Added support for WindowsStore
  6. On Android now it links to the log library for logging
  7. It no longer depends on clog and no longer provides the clog target, which is a breaking change and is causing build issues for some OSS libraries(like xnnpack)
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@snnn
Copy link
Member Author

snnn commented Dec 20, 2024

Need help here: the new cpuinfo version no longer needs clog. The change is causing problems for XNNPack. The new cpuinfo version doesn't work with older versions of XNNPack. So I also need to update XNNPack? But one PR should only update one port. What should I do? And, do I need to delete the older versions of cpuinfo?

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Dec 20, 2024
@LilyWangLL LilyWangLL changed the title Update cpuinfo to the latest version [cpuinfo] Update cpuinfo to the latest version Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants