Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[muparser] update to 2.3.5 #42789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[muparser] update to 2.3.5 #42789

wants to merge 1 commit into from
+21 −10

Conversation

MehdiChinoune
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li self-assigned this Dec 19, 2024
@Mengna-Li Mengna-Li added the category:port-update The issue is with a library, which is requesting update new revision label Dec 19, 2024
Mengna-Li
Mengna-Li requested changes Dec 19, 2024
View reviewed changes
ports/muparser/portfile.cmake Outdated Show resolved Hide resolved
ports/muparser/portfile.cmake Outdated Show resolved Hide resolved
@MehdiChinoune
Copy link
Contributor Author

Is it OK to add openmp to default-features?

@JonLiu1993
Copy link
Member

JonLiu1993 commented Dec 20, 2024 •
edited
Loading

Is it OK to add openmp to default-features?

Please do not add a feature as a default feature easily:
#42674 (comment)

@JonLiu1993 JonLiu1993 requested a review from Mengna-Li December 20, 2024 08:47
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@Mengna-Li Mengna-Li Awaiting requested review from Mengna-Li

Requested changes must be addressed to merge this pull request.

Assignees

@Mengna-Li Mengna-Li

Labels
category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MehdiChinoune @JonLiu1993 @Mengna-Li