-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fff] Add new port #42778
base: master
Are you sure you want to change the base?
[fff] Add new port #42778
Conversation
@microsoft-github-policy-service agree |
Regarding PR checklist item "The name of the port matches an existing name for this component on https://repology.org", the name I am not sure whether this is a genuine name clash, because I don't imagine the file manager In fact, on Conan Center, the library in this PR is named |
Co-authored-by: Frank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @salman-javed-nz, thank you for the contribution!
Do you mind changing the name of this port to meekrosoft-fff
to disambiguate from other packages with the same name? I see there are multiple hits for fff
on repology
ports/fff/portfile.cmake
Outdated
@@ -0,0 +1,12 @@ | |||
# Header-only library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Header-only library | |
set(VCPKG_BUILD_TYPE release) # Header-only library |
Both review comments addressed. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.