Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fff] Add new port #42778

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

salman-javed-nz
Copy link

@salman-javed-nz salman-javed-nz commented Dec 18, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@salman-javed-nz
Copy link
Author

@microsoft-github-policy-service agree

@salman-javed-nz
Copy link
Author

salman-javed-nz commented Dec 19, 2024

Regarding PR checklist item "The name of the port matches an existing name for this component on https://repology.org", the name fff is also the name of a file manager written in Bash script.

I am not sure whether this is a genuine name clash, because I don't imagine the file manager fff is something one would want to pull with vcpkg. The most popular C project named fff on GitHub, going by the number of stars and forks, is the library in this PR.

In fact, on Conan Center, the library in this PR is named fff (https://conan.io/center/recipes/fff).

@salman-javed-nz salman-javed-nz marked this pull request as ready for review December 19, 2024 01:02
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 19, 2024
ports/fff/portfile.cmake Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Dec 20, 2024
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @salman-javed-nz, thank you for the contribution!

Do you mind changing the name of this port to meekrosoft-fff to disambiguate from other packages with the same name? I see there are multiple hits for fff on repology

@@ -0,0 +1,12 @@
# Header-only library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Header-only library
set(VCPKG_BUILD_TYPE release) # Header-only library

@JavierMatosD JavierMatosD marked this pull request as draft December 20, 2024 20:43
@salman-javed-nz salman-javed-nz marked this pull request as ready for review December 21, 2024 01:54
@salman-javed-nz
Copy link
Author

Both review comments addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants