Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ls-qpack] Update, revise #42767

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ls-qpack] Update, revise #42767

wants to merge 3 commits into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 17, 2024

@Mengna-Li Mengna-Li self-assigned this Dec 18, 2024
@Mengna-Li Mengna-Li added category:port-update The issue is with a library, which is requesting update new revision depends:upstream-changes Waiting on a change to the upstream project labels Dec 18, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 18, 2024

This doesn't "DEPEND" on upstream changes. Of course we could wait for upstream acceptance of the changes, but in the meantime the port is partially broken.

@Mengna-Li
Copy link
Contributor

Let's wait for upstream approve or response.

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 19, 2024

This blocks improvements to downstream ports.

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 19, 2024

In particular, this PR enables the removal of pkg-config from the transitive usage requirements for the cmake config. Which is one step towards fixing the sad state of msh3's exported usage.

@talregev
Copy link
Contributor

talregev commented Dec 22, 2024

@Mengna-Li I agree with @dg0yt. He already notified upstream.
I already have similar condition when I export namespace cmake in ls-qpack. It was first merge in vcpkg, then upstream merge my PR without any response.
litespeedtech/ls-qpack#59
#40652

If you still don't agree, please review this port and we can have vcpkg team review, and let all team decide.

Thank you for your help and time to review this port 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants