Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libftp] Add new port #42124

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

deniskovalchuk
Copy link

@deniskovalchuk deniskovalchuk commented Nov 12, 2024

The project has the common name libftp, but it's already represented with that name in Conan and has a one-to-one match on https://repology.org/. Should I change something in this part?

  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@deniskovalchuk deniskovalchuk marked this pull request as ready for review November 12, 2024 19:15
@Mengna-Li Mengna-Li added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 13, 2024
ports/libftp/portfile.cmake Outdated Show resolved Hide resolved
"description": "A cross-platform FTP/FTPS client library based on Boost.Asio.",
"homepage": "https://github.com/deniskovalchuk/libftp",
"license": "MIT",
"supports": "!uwp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you are the owner of this port. I did not see any description on the homepage of the port that does not support UWP. I would like to confirm if libftp doesn't support the UWP.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this port isn't intended for UWP.

@Mengna-Li
Copy link
Contributor

Usage tested pass on x64-windows.

@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants