-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libftp] Add new port #42124
base: master
Are you sure you want to change the base?
[libftp] Add new port #42124
Conversation
"description": "A cross-platform FTP/FTPS client library based on Boost.Asio.", | ||
"homepage": "https://github.com/deniskovalchuk/libftp", | ||
"license": "MIT", | ||
"supports": "!uwp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you are the owner of this port. I did not see any description on the homepage of the port that does not support UWP. I would like to confirm if libftp
doesn't support the UWP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this port isn't intended for UWP.
Usage tested pass on |
The project has the common name
libftp
, but it's already represented with that name in Conan and has a one-to-one match on https://repology.org/. Should I change something in this part?find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.