Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zoe] Update to v3.5 #42105

Open
wants to merge 119 commits into
base: master
Choose a base branch
from
Open

[zoe] Update to v3.5 #42105

wants to merge 119 commits into from

Conversation

winsoft666
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 12, 2024
"maintainers": "winsoft666 <[email protected]>",
"description": "C++ File Download Library.",
"homepage": "https://github.com/winsoft666/zoe",
"supports": "!osx & !uwp & !arm & !android",
"supports": "!uwp & !arm & !android",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream begins to support macOS: https://github.com/winsoft666/zoe/releases/tag/v3.4.

MonicaLiu0311
MonicaLiu0311 previously approved these changes Nov 12, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 12, 2024

Modern macOS means arm64. But arm is marked as unsupported.
Shouldn't this be fixed before merging the update?

@MonicaLiu0311 MonicaLiu0311 removed the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@winsoft666 winsoft666 changed the title [zoe] Update to v3.4 [zoe] Update to v3.5 Nov 12, 2024
Comment on lines 7 to 11
},
{
"git-tree": "af971f67231a4122a1b8524e89bd6c50eaffab5a",
"version": "3.4",
"port-version": 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
{
"git-tree": "af971f67231a4122a1b8524e89bd6c50eaffab5a",
"version": "3.4",
"port-version": 0

@JonLiu1993 JonLiu1993 marked this pull request as draft November 13, 2024 02:59
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@winsoft666 winsoft666 marked this pull request as ready for review November 13, 2024 04:06
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants