-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add internal setters to input types #3238
Merged
m-nash
merged 22 commits into
microsoft:main
from
ArcturusZhang:add-internal-setters-to-input-types
May 21, 2024
Merged
add internal setters to input types #3238
m-nash
merged 22 commits into
microsoft:main
from
ArcturusZhang:add-internal-setters-to-input-types
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
force-pushed
the
add-internal-setters-to-input-types
branch
from
April 26, 2024 05:43
69d0551
to
bf83cd2
Compare
ArcturusZhang
force-pushed
the
add-internal-setters-to-input-types
branch
from
April 26, 2024 05:53
bf83cd2
to
40d0826
Compare
ArcturusZhang
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
April 29, 2024 09:14
jorgerangel-msft
approved these changes
May 6, 2024
m-nash
reviewed
May 6, 2024
...p-client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputApiKeyAuth.cs
Outdated
Show resolved
Hide resolved
bterlson
changed the title
feat(http-client-csharp): add internal setters to input types
add internal setters to input types
May 10, 2024
ArcturusZhang
commented
May 11, 2024
...tp-client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputModelType.cs
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
m-nash
added
feature
New feature or request
and removed
bug
Something isn't working
labels
May 13, 2024
m-nash
reviewed
May 13, 2024
...http-client-csharp/generator/Microsoft.Generator.CSharp.Input/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
...lient-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputIntrinsicType.cs
Outdated
Show resolved
Hide resolved
m-nash
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Azure/autorest.csharp#4587