Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add internal setters to input types #3238

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Apr 26, 2024

@ArcturusZhang ArcturusZhang force-pushed the add-internal-setters-to-input-types branch from 69d0551 to bf83cd2 Compare April 26, 2024 05:43
@ArcturusZhang ArcturusZhang force-pushed the add-internal-setters-to-input-types branch from bf83cd2 to 40d0826 Compare April 26, 2024 05:53
@ArcturusZhang ArcturusZhang marked this pull request as ready for review April 29, 2024 09:14
@bterlson bterlson added emitter:client:csharp bug Something isn't working labels May 10, 2024
@bterlson bterlson changed the title feat(http-client-csharp): add internal setters to input types add internal setters to input types May 10, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 11, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.Input

@m-nash m-nash added feature New feature or request and removed bug Something isn't working labels May 13, 2024
@m-nash m-nash enabled auto-merge May 21, 2024 17:24
@m-nash m-nash added this pull request to the merge queue May 21, 2024
Merged via the queue into microsoft:main with commit f70cdb9 May 21, 2024
21 checks passed
@ArcturusZhang ArcturusZhang deleted the add-internal-setters-to-input-types branch May 22, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly set inits on InputType's Properties
5 participants