Refactor symbol handling by introducing new name resolution phase #2640
Conversation
bterlson
requested review from
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2640/ |
packages/compiler/src/core/links.ts
Outdated
| node: TypeReferenceNode | MemberExpressionNode | IdentifierNode, | ||
| mapper: TypeMapper | undefined, | ||
| instantiateTemplate = true | ||
| ): { sym: Sym | null; type: Type } { |
There was a problem hiding this comment.
i never fully get when we should use null, always try to stick to undefined so you don't have to check for multiple things
There was a problem hiding this comment.
I tend to use null for an explicit no thing value since undefined crops up randomly, but do note that much of this code will be completely rewritten once the resolver is operational.
| } else if (symbolLinks.declaredType) { | ||
| baseType = symbolLinks.declaredType; | ||
| } else if (sym.flags & SymbolFlags.Member) { | ||
| baseType = checkMemberSym(sym, mapper); | ||
| } else { | ||
| baseType = checkDeclaredType(sym, decl, mapper); | ||
| baseType = getTypeForNode(decl, mapper); |
There was a problem hiding this comment.
All the checker changes were from when I thought I could fix everything without refactoring how symbols work.
| @@ -1177,6 +1250,9 @@ export function createChecker(program: Program): Checker { | |||
| parentMapper: TypeMapper | undefined, | |||
| instantiateTempalates = true | |||
| ): Type { | |||
| if (templateNode.id.sv === "bar") { | |||
This is nowhere near ready, but putting up in draft PR to share progress.
The goals of this change:
Details about the approach can be found in the comment at the top of
name-resolver.ts.