some update

packages/typespec-vscode/src/extension.ts

@@ -98,10 +98,10 @@ export async function activate(context: ExtensionContext) {
   );
 
   // Only try to start language server when some workspace has opened
-  // because the LSP client will popup error notification in vscode directly if failed to start (not our code, but in LanguageClient class...)
-  // which will be confusing to user if no workspace is opened (i.e. create TypeSpec project scenario)
+  // because the LanguageClient class will popup error notification in vscode directly if failing to start
+  // which will be confusing to user if no workspace is opened (i.e. in Create TypeSpec project scenario)
   if ((vscode.workspace.workspaceFolders?.length ?? 0) > 0) {
-    await vscode.window.withProgress(
+    return await vscode.window.withProgress(
       {
         title: "Launching TypeSpec language service...",
         location: vscode.ProgressLocation.Notification,

packages/typespec-vscode/src/tsp-language-client.ts

@@ -145,7 +145,7 @@ export class TspLanguageClient {
   async start(): Promise<void> {
     try {
       if (this.client.needsStart()) {
-        // please be aware that this method may also popup error notification directly in vscode
+        // please be aware that this method would popup error notification in vscode directly
         await this.client.start();
         logger.info("TypeSpec server started");
       } else {

packages/typespec-vscode/src/types.ts

@@ -19,10 +19,6 @@ export interface InstallGlobalCliCommandArgs {
   confirm: boolean;
   confirmTitle?: string;
   confirmPlaceholder?: string;
-  /**
-   * The command won't show output window or popup notification in silent mode
-   */
-  silentMode?: boolean;
 }
 
 export interface RestartServerCommandArgs {

packages/typespec-vscode/src/utils.ts

@@ -279,8 +279,8 @@ export function spawnExecution(
 }
 
 /**
- * if the operation is cancelled, the promise will be rejected with @{link ResultCode.Cancelled}
- * if the operation is timeout, the promise will be rejected with @{link ResultCode.Timeout}
+ * if the operation is cancelled, the promise will be rejected with {@link ResultCode.Cancelled}
+ * if the operation is timeout, the promise will be rejected with {@link ResultCode.Timeout}
  *
  * @param action
  * @param token

packages/typespec-vscode/src/vscode-cmd/create-tsp-project.ts

@@ -659,7 +659,8 @@ async function checkProjectRootFolderEmpty(selectedFolder: string): Promise<bool
 async function CheckCompilerAndStartLSPClient(folder: string): Promise<Result<TspLanguageClient>> {
   // language server may not be started because no workspace is opened or failed to start for some reason
   // so before trying to start it, let's try to check whether global compiler is available first
-  // to avoid unnecessary error notification when starting LSP which would be confusing.
+  // to avoid unnecessary error notification when starting LSP which would be confusing (we can't avoid it which
+  // is from base LanguageClient class...).
   const r = await IsGlobalCompilerAvailable(folder);
   if (r.code !== ResultCode.Success || r.value === undefined) {
     return { code: r.code, details: r.details };
@@ -670,7 +671,6 @@ async function CheckCompilerAndStartLSPClient(folder: string): Promise<Result<Ts
       confirmTitle: "No TypeSpec Compiler/CLI found which is needed to create TypeSpec project.",
       confirmPlaceholder:
         "No TypeSpec Compiler/CLI found which is needed to create TypeSpec project.",
-      silentMode: true,
     };
     const result = await vscode.commands.executeCommand<Result<void>>(
       CommandName.InstallGlobalCompilerCli,

packages/typespec-vscode/src/vscode-cmd/install-tsp-compiler.ts

@@ -9,8 +9,6 @@ const COMPILER_REQUIREMENT =
 export async function installCompilerGlobally(
   args: InstallGlobalCliCommandArgs | undefined,
 ): Promise<Result<void>> {
-  const showOutput = !(args?.silentMode ?? false);
-  const showPopup = !(args?.silentMode ?? false);
   // confirm with end user by default
   if (args?.confirm !== false) {
     const yes: QuickPickItem = {
@@ -55,7 +53,7 @@ export async function installCompilerGlobally(
           logger.error(
             "Failed to install TypeSpec CLI. Please check the previous log for details",
             [output],
-            { showOutput, showPopup },
+            { showOutput: true, showPopup: true },
           );
           return {
             code: ResultCode.Fail,
@@ -71,14 +69,14 @@ export async function installCompilerGlobally(
           return { code: ResultCode.Cancelled };
         } else if (e === ResultCode.Timeout) {
           logger.error(`Installation of TypeSpec Compiler/CLI is timeout after ${TIMEOUT}ms`, [e], {
-            showOutput,
-            showPopup,
+            showOutput: true,
+            showPopup: true,
           });
           return { code: ResultCode.Timeout };
         } else {
           logger.error("Unexpected error when installing TypeSpec Compiler/CLI", [e], {
-            showOutput,
-            showPopup,
+            showOutput: true,
+            showPopup: true,
           });
           return { code: ResultCode.Fail, details: e };
         }