Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sourcegen #3880

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
cc0d3be
Update source gen
nohwnd Sep 27, 2024
990d154
Get assembly
nohwnd Sep 30, 2024
0969391
Update source generation to latest
nohwnd Sep 30, 2024
45cb700
Merge branch 'main' into update-sourcegen
nohwnd Sep 30, 2024
acec139
down to just trim and aot warnings from libs
nohwnd Oct 1, 2024
b21bf50
revert proj
nohwnd Oct 1, 2024
2b6ee6c
fixes
nohwnd Oct 1, 2024
8294a2d
fixes
nohwnd Oct 1, 2024
b546d0c
Merge branch 'main' into update-sourcegen
Evangelink Oct 31, 2024
0f8c9cb
Merge branch 'main' into update-sourcegen
Evangelink Nov 1, 2024
c4a2bb8
Extend test with different init/cleanup attributes
Nov 5, 2024
2520e34
Fix cleanup methods in test
Nov 5, 2024
0b651fa
Revert VersionPrefix change and update source gen
Youssef1313 Nov 6, 2024
91414af
Merge branch 'main' into update-sourcegen
Youssef1313 Nov 6, 2024
e89c7d3
Update Version.Details.xml as well
Youssef1313 Nov 6, 2024
b0ead66
Revert launchSettings.json change
Youssef1313 Nov 6, 2024
e298e0a
Add more tests for native AOT
Youssef1313 Nov 6, 2024
def4e8b
Refactor tests, add more tests
Youssef1313 Nov 6, 2024
ad94d29
Fix typo
Youssef1313 Nov 6, 2024
88ff2bc
Address analyzer warning
Youssef1313 Nov 6, 2024
9477851
More tests
Youssef1313 Nov 6, 2024
873bd97
Formatting error
Youssef1313 Nov 8, 2024
5e41dba
Move to UnconditionalSuppressMessage attribute
Youssef1313 Nov 8, 2024
430bb08
Suppress
Youssef1313 Nov 12, 2024
31001ac
Avoid using #pragma warning disable ILxxxx
Youssef1313 Nov 19, 2024
ce4198b
Merge branch 'main' into update-sourcegen
Youssef1313 Nov 21, 2024
04f6470
Adjust
Youssef1313 Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Combine the tests in a single project so that we do the dotnet publish only once.

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class NativeAotTests : AcceptanceTestBase
<UseAppHost>true</UseAppHost>
<LangVersion>preview</LangVersion>
<PublishAot>true</PublishAot>
<NoWarn>$(NoWarn);IL2104;IL2026;IL3053</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self: This should be removed before we can merge.

<!--
This makes sure that the project is referencing MSTest.TestAdapter.dll when MSTest.TestAdapter nuget is imported,
without this the dll is just copied into the output folder.
Expand Down Expand Up @@ -48,7 +49,7 @@ public static void ClassInit(TestContext testContext)
}

[ClassCleanup]
public static void ClassClean(TestContext testContext)
public static void ClassClean()
{
}

Expand All @@ -68,7 +69,7 @@ public static void AssemblyInit(TestContext testContext)
}

[AssemblyCleanup]
public static void AssemblyClean(TestContext testContext)
public static void AssemblyClean()
{
}

Expand Down
Loading