-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sourcegen #3880
Draft
nohwnd
wants to merge
27
commits into
main
Choose a base branch
from
update-sourcegen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update sourcegen #3880
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cc0d3be
Update source gen
nohwnd 990d154
Get assembly
nohwnd 0969391
Update source generation to latest
nohwnd 45cb700
Merge branch 'main' into update-sourcegen
nohwnd acec139
down to just trim and aot warnings from libs
nohwnd b21bf50
revert proj
nohwnd 2b6ee6c
fixes
nohwnd 8294a2d
fixes
nohwnd b546d0c
Merge branch 'main' into update-sourcegen
Evangelink 0f8c9cb
Merge branch 'main' into update-sourcegen
Evangelink c4a2bb8
Extend test with different init/cleanup attributes
2520e34
Fix cleanup methods in test
0b651fa
Revert VersionPrefix change and update source gen
Youssef1313 91414af
Merge branch 'main' into update-sourcegen
Youssef1313 e89c7d3
Update Version.Details.xml as well
Youssef1313 b0ead66
Revert launchSettings.json change
Youssef1313 e298e0a
Add more tests for native AOT
Youssef1313 def4e8b
Refactor tests, add more tests
Youssef1313 ad94d29
Fix typo
Youssef1313 88ff2bc
Address analyzer warning
Youssef1313 9477851
More tests
Youssef1313 873bd97
Formatting error
Youssef1313 5e41dba
Move to UnconditionalSuppressMessage attribute
Youssef1313 430bb08
Suppress
Youssef1313 31001ac
Avoid using #pragma warning disable ILxxxx
Youssef1313 ce4198b
Merge branch 'main' into update-sourcegen
Youssef1313 04f6470
Adjust
Youssef1313 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ public class NativeAotTests : AcceptanceTestBase | |
<UseAppHost>true</UseAppHost> | ||
<LangVersion>preview</LangVersion> | ||
<PublishAot>true</PublishAot> | ||
<NoWarn>$(NoWarn);IL2104;IL2026;IL3053</NoWarn> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to self: This should be removed before we can merge. |
||
<!-- | ||
This makes sure that the project is referencing MSTest.TestAdapter.dll when MSTest.TestAdapter nuget is imported, | ||
without this the dll is just copied into the output folder. | ||
|
@@ -48,7 +49,7 @@ public static void ClassInit(TestContext testContext) | |
} | ||
|
||
[ClassCleanup] | ||
public static void ClassClean(TestContext testContext) | ||
public static void ClassClean() | ||
{ | ||
} | ||
|
||
|
@@ -68,7 +69,7 @@ public static void AssemblyInit(TestContext testContext) | |
} | ||
|
||
[AssemblyCleanup] | ||
public static void AssemblyClean(TestContext testContext) | ||
public static void AssemblyClean() | ||
{ | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Combine the tests in a single project so that we do the
dotnet publish
only once.