Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple regressions since #18215 #18345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix multiple regressions since #18215 #18345

wants to merge 1 commit into from
+49 −29

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Dec 20, 2024

Fixes

  • Cursor vanishing, because 
    CoreWindow::GetForCurrentThread().PointerCursor()
    returned a non-null, but still invisible cursor.
  • Alt/F7 not dispatching to newly created windows, because the
    WM_ACTIVATE message now arrives before the AppHost is initialized.
    This caused the messages to be delivered to old windows.
  • Windows Terminal blocking expedited shutdown,
    because we return FALSE on non-ENDSESSION_CLOSEAPP messages.

Closes #18331
Closes #18335

Validation Steps Performed

  • Cursor still doesn't really vanish for me in the first place ✅
  • Alt/F7 work in new windows without triggering old ones ✅

@lhecker lhecker changed the title Pass foreground rights to the emperor Fix multiple regressions since #18215 Dec 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-Windowing Window frame, quake mode, tearout Priority-1 A description (P1) Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Dec 20, 2024
DHowett
DHowett approved these changes Dec 22, 2024
View reviewed changes
src/cascadia/WindowsTerminal/WindowEmperor.cpp
const auto hwnd = msg.hwnd;
AppHost* window = nullptr;

// Just in case someone has targed a specific HWND,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targeted

Suggested change
// Just in case someone has targed a specific HWND,
// Just in case someone has targeted a specific HWND,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mouse pointer "vanishes" when moved over Terminal Window Alt and F7 don't work in 1.23.3481.0
2 participants
@lhecker @DHowett