Add the ability to show the tab bar in fullscreen

[GeekJosh]

Summary of the Pull Request

This PR allows users to enable the tab bar in fullscreen mode.

References and Relevant Issues

This PR is in response to #11130

Detailed Description of the Pull Request / Additional comments

A new setting; "showTabsFullscreen"; has been added which accepts a boolean value. When true, then the tab bar will remain visible when the terminal app is fullscreen. If the value is false (default), then the tab bar is hidden in fullscreen.

When the tab bar is visible in fullscreen, the min/max/close controls are hidden to maintain the expected behaviour of a fullscreen app.

Validation Steps Performed

All unit tests are passing.

Manually verified that when the "launchMode" setting is "fullscreen" and the "showTabsFullscreen" setting is true, the tab bar is visible on launch.

Manually verified that changing the setting at runtime causes the tab bar to be shown/hidden immediately (if the terminal is currently fullscreen).

Manually verified that the new "showTabsFullscreen" setting is honoured regardless of whether "showTabsInTitlebar" is set to true or false.

PR Checklist

• Closes No tabs in fullscreen, focus mode or not #11130
• Tests added/passed
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #813
• Schema updated (if necessary)

[carlos-zamora]

Looks great! Thanks for doing this!

[GeekJosh]

Looks great! Thanks for doing this!

No problem at all, I enjoyed doing it 🙂

Thanks for the review

[GeekJosh]

I'm not sure what's causing the Release/x86 build failure here; I can build locally without any issues.

I did a bit of searching and found that there was some issue with the pipeline previously which resulted in the same error: #14581

In that thread, @zadjii-msft found that the GUID used for a dependency project of the TerminalAzBridge project was wrong (PR: #15008) and, sure enough, that's the project which is failing to build for this PR too.

I can't see that anything has changed recently in that project, nor any recent changes to the solution (other than the addition of a new project), so not sure how to proceed from here?

[zadjii-msft]

Thanks for digging in! Alas, I think you just found one of our various transient build failures. The "circular dependency" thing crops up once every 25 builds or so. You just got unlucky 🤷

I kicked the build though, so hopefully it'll pop up green this time ☺️

[zadjii-msft]

Thanks for doing this! This looks much better without the extra event ☺️

[zadjii-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[DHowett]

Thanks for doing this!

I didn't see any notes about how this interoperates with "Hide the title bar". I think it will work given the tab view visibility work in TabManagement.cpp, but would you mind confirming that?

Thanks!

[GeekJosh]

Thanks for doing this!

I didn't see any notes about how this interoperates with "Hide the title bar". I think it will work given the tab view visibility work in TabManagement.cpp, but would you mind confirming that?

Thanks!

Sorry for the delay in responding! Full screen tabs show with or without the title bar hidden - I did two screenshots to show it before realising they prove nothing as there is no title bar in full screen either way 🤦

Probably doesn't hurt to show what they look like anyway, so here are those screenshots, first with the tite bar hidden:

And with the title bar not hidden (in settings at least 😅):

[DHowett]

LOL, thanks for jumping through my hoops. Sorry if I made you re-break the spell checker.

As for workflow: we squash all pull requests, so you are free to merge or rebase as you see fit. We usually use merges for in-progress work, because even though it makes for an uglier history it keeps GitHub from destroying PR comments attached to specific files and lines.

[GeekJosh]

LOL, thanks for jumping through my hoops. Sorry if I made you re-break the spell checker.

As for workflow: we squash all pull requests, so you are free to merge or rebase as you see fit. We usually use merges for in-progress work, because even though it makes for an uglier history it keeps GitHub from destroying PR comments attached to specific files and lines.

Thank you for explaining 🙂