Skip to content

Commit

Permalink
build: add a couple more signing variables to ESRP (#18411)
Browse files Browse the repository at this point in the history
This is in support of some identity changes we need to make.
  • Loading branch information
DHowett authored Jan 8, 2025
1 parent b25fe55 commit a3a4464
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions build/pipelines/ob-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ extends:
akvName: $(SigningAKVName)
authCertName: $(SigningAuthCertName)
signCertName: $(SigningSignCertName)
useManagedIdentity: $(SigningUseManagedIdentity)
clientId: $(SigningOriginalClientId)
publishSymbolsToPublic: true
publishVpackToWindows: false
symbolExpiryTime: 15
Expand Down
2 changes: 2 additions & 0 deletions build/pipelines/ob-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ extends:
akvName: $(SigningAKVName)
authCertName: $(SigningAuthCertName)
signCertName: $(SigningSignCertName)
useManagedIdentity: $(SigningUseManagedIdentity)
clientId: $(SigningOriginalClientId)
terminalInternalPackageVersion: ${{ parameters.terminalInternalPackageVersion }}
publishSymbolsToPublic: ${{ parameters.publishSymbolsToPublic }}
publishVpackToWindows: ${{ parameters.publishVpackToWindows }}
Expand Down
2 changes: 2 additions & 0 deletions build/pipelines/templates-v2/steps-esrp-signing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ steps:
AuthAKVName: ${{ parameters.signingIdentity.akvName }}
AuthCertName: ${{ parameters.signingIdentity.authCertName }}
AuthSignCertName: ${{ parameters.signingIdentity.signCertName }}
UseMSIAuthentication: ${{ coalesce(parameters.signingIdentity.useManagedIdentity, 'false') }}
EsrpClientId: ${{ parameters.signingIdentity.clientId }}
${{ insert }}: ${{ parameters.inputs }}

0 comments on commit a3a4464

Please sign in to comment.