refactor(eslint-plugin): refactor 'react' config (#3396)

microsoft · Oct 17, 2024 · 8502d48 · 8502d48
1 parent 57013d2
commit 8502d48
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/.changeset/great-ways-end.md b/.changeset/great-ways-end.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/eslint-plugin/src/configs/react.js b/packages/eslint-plugin/src/configs/react.js
@@ -13,4 +13,15 @@ const compat = new FlatCompat({
 module.exports = [
   ...compat.extends("plugin:react-hooks/recommended"),
   react.configs.flat.recommended,
+  {
+    name: "rnx-kit/react",
+    rules: {
+      "react/prop-types": "off",
+    },
+    settings: {
+      react: {
+        version: "detect",
+      },
+    },
+  },
 ];
diff --git a/packages/eslint-plugin/src/configs/recommended.js b/packages/eslint-plugin/src/configs/recommended.js
@@ -16,14 +16,14 @@ function isInstalled(spec) {
   }
 }
 
-const usesReact = isInstalled("react");
-const reactConfigs = usesReact ? require("./react") : [];
+const reactConfigs = isInstalled("react") ? require("./react") : [];
 
 module.exports = [
   eslint.configs.recommended,
   ...tseslint.configs.recommended,
   ...reactConfigs,
   {
+    name: "rnx-kit/recommended",
     plugins: {
       // @ts-expect-error No declaration file for module
       "@react-native": require("@react-native/eslint-plugin"),
@@ -53,12 +53,6 @@ module.exports = [
       ],
       "@typescript-eslint/no-var-requires": "off",
       "no-undef": "off",
-      ...(usesReact ? { "react/prop-types": "off" } : {}),
-    },
-    settings: {
-      react: {
-        version: "detect",
-      },
     },
   },
 ];