Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retina-shell image for Linux #928

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

wedaly
Copy link
Member

@wedaly wedaly commented Nov 1, 2024

Description

Build a new image retina-shell for adhoc network debugging on Linux nodes/pods.

Related Issue

#910

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Tested building with the following commands:

IMAGE_REGISTRY=widalytest.azurecr.io BUILDX_ACTION=--push PLATFORM=linux/amd64 make retina-shell-image
IMAGE_REGISTRY=widalytest.azurecr.io BUILDX_ACTION=--push PLATFORM=linux/arm64 make retina-shell-image
IMAGE_REGISTRY=widalytest.azurecr.io BUILDX_ACTION=--push make manifest-shell-image

Then ran it locally:
image

Additional Notes

There are two issues with the AzLinux 3 base image that should be fixed in the upcoming AzLinux3 release. See comments in the Dockerfile for details.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@wedaly wedaly requested a review from a team as a code owner November 1, 2024 22:34
shell/Dockerfile Outdated Show resolved Hide resolved
@nddq nddq added this pull request to the merge queue Nov 4, 2024
Merged via the queue into microsoft:main with commit d39e36d Nov 4, 2024
22 checks passed
@wedaly wedaly deleted the retina-shell-image branch November 4, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants