-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add e2e tests to validate hubble-relay and hubble-ui deployment #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhabMajumdar
previously approved these changes
Oct 29, 2024
nddq
requested changes
Nov 4, 2024
jimassa
previously approved these changes
Nov 6, 2024
nddq
previously approved these changes
Nov 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2024
Signed-off-by: Yilin <[email protected]>
ibezrukavyi
previously approved these changes
Nov 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
#896) # Description Add e2e tests to validate Hubble-relay and Hubble-UI deployment, in order not to touch the legacy test, the install-helm-chart func was re-written again. The test Hubble job is able to validate Hubble resource and basic metrics but not migrating all the advanced metrics validation since there are many heavy liftings work remain and could be addressed in the future migration. ## Related Issue #422 ## Checklist - [ ] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [ ] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [ ] I have correctly attributed the author(s) of the code. - [ ] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed <img width="925" alt="image" src="https://github.com/user-attachments/assets/fa0207b7-c004-4a34-a9d4-8cef09fff327"> ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Yilin <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
ibezrukavyi
approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e tests to validate Hubble-relay and Hubble-UI deployment, in order not to touch the legacy test, the install-helm-chart func was re-written again. The test Hubble job is able to validate Hubble resource and basic metrics but not migrating all the advanced metrics validation since there are many heavy liftings work remain and could be addressed in the future migration.
Related Issue
#422
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.