Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add e2e tests to validate hubble-relay and hubble-ui deployment #896

Merged
merged 14 commits into from
Nov 19, 2024

Conversation

xiaozhiche320
Copy link
Contributor

@xiaozhiche320 xiaozhiche320 commented Oct 25, 2024

Description

Add e2e tests to validate Hubble-relay and Hubble-UI deployment, in order not to touch the legacy test, the install-helm-chart func was re-written again. The test Hubble job is able to validate Hubble resource and basic metrics but not migrating all the advanced metrics validation since there are many heavy liftings work remain and could be addressed in the future migration.

Related Issue

#422

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@xiaozhiche320 xiaozhiche320 self-assigned this Oct 25, 2024
@xiaozhiche320 xiaozhiche320 requested a review from a team as a code owner October 25, 2024 16:46
@nddq nddq linked an issue Oct 31, 2024 that may be closed by this pull request
@nddq nddq added this pull request to the merge queue Oct 31, 2024
@xiaozhiche320 xiaozhiche320 removed this pull request from the merge queue due to a manual request Oct 31, 2024
test/e2e/retina_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/hubble/scenario.go Show resolved Hide resolved
jimassa
jimassa previously approved these changes Nov 6, 2024
nddq
nddq previously approved these changes Nov 8, 2024
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@xiaozhiche320 xiaozhiche320 dismissed stale reviews from jimassa and nddq via a161652 November 18, 2024 19:56
ibezrukavyi
ibezrukavyi previously approved these changes Nov 18, 2024
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
#896)

# Description

Add e2e tests to validate Hubble-relay and Hubble-UI deployment, in
order not to touch the legacy test, the install-helm-chart func was
re-written again. The test Hubble job is able to validate Hubble
resource and basic metrics but not migrating all the advanced metrics
validation since there are many heavy liftings work remain and could be
addressed in the future migration.

## Related Issue

#422

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

<img width="925" alt="image"
src="https://github.com/user-attachments/assets/fa0207b7-c004-4a34-a9d4-8cef09fff327">

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Yilin <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Nov 18, 2024
@xiaozhiche320 xiaozhiche320 removed this pull request from the merge queue due to a manual request Nov 18, 2024
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into microsoft:main with commit 8db4de4 Nov 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Add e2e tests to validate hubble-relay and hubble-ui deployment
5 participants