fix: Adding service monitor for retina-operator #848
Conversation
mereta
changed the title
|
@microsoft-github-policy-service agree company="Microsoft" |
Working on it! ✅ |
@SRodi I will hold off on the Hubble charts. I ran in to a few issues with the operator, I cant seem to get any metrics form /metrics endpoint. It seems to be different to the legacy operator. I reached out to @rbtr to have a look and maybe advide. |
mereta
force-pushed
the
mereta/svcmonitor
branch
from
6d8dd26
to
cd7a94c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@mereta it looks like E2E tests need to be updated as part of this PR - see this failure https://github.com/microsoft/retina/actions/runs/11331610343/job/31512301186#step:6:213 runner.go:27:
Error Trace: /home/runner/work/retina/retina/test/e2e/framework/types/runner.go:27
/home/runner/work/retina/retina/test/e2e/retina_e2e_test.go:77
Error: Received unexpected error:
did not expect error from step InstallHelmChart but got error: failed to install chart: unable to build kubernetes objects from release manifest: resource mapping not found for name: "retina-operator-servicemonitor" namespace: "kube-system" from "": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first
Test: TestE2ERetina |
I'm going to create a separate PR for this. The ServiceMonitor CRD is not available in the cluster, as prometheus is not installed. |
There was a problem hiding this comment.
Thanks @mereta! Just to clarify for everyone: retina-operator ServiceMonitor is currently disabled as we need to update E2E tests to install Prometheus ServiceMonitor CRDs - that will be captured in separate GH issue and tackled in another PR.
…a-operator (#870) # Description For a ServiceMonitor to be default way of getting Prometheus metrics from retina-operator, ServiceMonitor CRD needs to be installed for the e2e test flow. Missing CRD causes test to fail. ## Related Issue A ServiecMonitor was added in the PR below but was disabled, due to e2e issue. #848 This PR resolves that issue. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
# Description Disabling the Service Monitor, we need to find a way to install Prometheus CRD's as part of retina. ## Related Issue #848 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
Description
Adding a ServiceMonitor for retina-operator
Related Issue
retina-operator wasn't being scraped for metrics by prometheus.
Initially it was appearing in the 'retina-pods' job and failing as reported in this issue:
#738
Partial fix was merged to remove the operator pod from the list here:
#770
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Operator specific metrics with job='retina-operator' selector:
Additional Notes
Proposed next steps is to align the way we add scrap configs:
#847
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.