Fix kubectl-retina version
#1023
+116
−34
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,11 +11,20 @@ import ( | |
| "github.com/microsoft/retina/internal/buildinfo" | ||
| ) | ||
|
|
||
| // This variable is used by the "version" command and is set during build. | ||
| // Default to a safe value if not set. | ||
| var defaultVersion = "v0.0.5" | ||
|
There was a problem hiding this comment. Wouldn't it be a misleading info? I don't think it makes sense to have a "default" version There was a problem hiding this comment. Yeah, I'd almost rather an empty string here and a loud notification that this wasn't set by some pipeline. |
||
|
|
||
| var version = &cobra.Command{ | ||
| Use: "version", | ||
| Short: "Show version", | ||
| Run: func(*cobra.Command, []string) { | ||
| if buildinfo.Version != "" { | ||
| fmt.Println(buildinfo.Version) | ||
| } else { | ||
| fmt.Println("buildinfo.Version is not set successfully, showing default version:") | ||
| fmt.Println(defaultVersion) | ||
|
Comment on lines
+25
to
+26
There was a problem hiding this comment. I think you can probably get a more useful "default" value out of https://pkg.go.dev/runtime/debug#BuildInfo . There's a property in there for the |
||
| } | ||
| }, | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the debug lines before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 . We should remove the debug lines.