Add children to the props for @types/react@18 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2022
sea-dhassouni
approved these changes
May 11, 2022
robtenorio
approved these changes
May 11, 2022
|
Any update here? No way to switch to React 18 without this fix |
abettadapur
approved these changes
Jun 2, 2022
|
Can we get this merged? |
|
I am unfortunately not an admin on this project anymore, so I am unable to bypass a broken CI check |
|
Any update on this ? it would be nice if could merge this PR. |
|
Can this get merged and released? Waiting on this fix. |
|
Any updates on when this will be merged? |
avianate
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to React props should not do anything special with
childrenand DefinitelyTyped have updated the react types to v18DefinitelyTyped/DefinitelyTyped#59802