-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): snapshotPathTemplate
as optional funtion
#34127
base: main
Are you sure you want to change the base?
feat(config): snapshotPathTemplate
as optional funtion
#34127
Conversation
410a7f5
to
c88e21a
Compare
This comment has been minimized.
This comment has been minimized.
c88e21a
to
1da4ae1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality is stable, docs aren't
@@ -1751,7 +1751,7 @@ await Expect(Page.GetByTitle("Issues count")).toHaveText("25 issues"); | |||
``` | |||
|
|||
## test-config-snapshot-path-template | |||
- `type` ?<[string]> | |||
- `type` ?<[string]|[SnapshotPathResolver]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I import SnapshotPathResolver
into the generated .d.ts file?
This comment has been minimized.
This comment has been minimized.
@microsoft-github-policy-service agree |
1da4ae1
to
4d0db50
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 fatal errors, not part of any test 10 flaky37198 passed, 645 skipped Merge workflow run. |
closes #33098
replaces #33420
This PR adds to possibility to pass a function to
snapshotPathTemplate
, allowing full runtime control over snapshot names.I am not sure the name fits this functionality so it might be better to add this as a standalone option.