Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding assert failures for service config #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding assert failures for service config #25

wants to merge 1 commit into from

Conversation

puagarwa
Copy link
Member

@puagarwa puagarwa commented Sep 5, 2023

Adding assert failures for service config

@puagarwa puagarwa requested a review from vvs11 September 5, 2023 06:13
@vvs11 vvs11 requested a review from johnsta September 5, 2023 07:21
ntrogh
ntrogh reviewed Sep 26, 2023
View reviewed changes
samples/get-started/playwright.service.config.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use PLAYWRIGHT_SERVICE_ACCESS_TOKEN instead of PLAYWRIGHT_SERVICE_ACCESS_KEY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntrogh ntrogh ntrogh left review comments

@vvs11 vvs11 Awaiting requested review from vvs11

@johnsta johnsta Awaiting requested review from johnsta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puagarwa @ntrogh