Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress some warnings in WebGPU EP generated by GCC 13 #23445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Suppress some warnings in WebGPU EP generated by GCC 13 #23445

wants to merge 3 commits into from
+20 −5

Conversation

snnn
Copy link
Member

@snnn snnn commented Jan 21, 2025 •
edited
Loading

Suppress some warnings generated by GCC 13 by introducing a wrapper for WebGPU header files.

@snnn snnn requested a review from fs-eire January 21, 2025 20:12
@fs-eire
Copy link
Contributor

fs-eire commented Jan 21, 2025

It would be helpful for future tracking if we can split the changes in this PR into:

  • related to include onnx_protobuf.h
  • other issues

Some issues related to strict aliasing may be fixed by using std::bit_cast, which requires c++20 however.

@snnn
Copy link
Member Author

snnn commented Jan 21, 2025

Created #23454 and #23453

@snnn snnn changed the title Suppress some warnings generated by GCC 13 Suppress some warnings in WebGPU EP generated by GCC 13 Jan 22, 2025
@snnn snnn added the ep:WebGPU ort-web webgpu provider label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire Awaiting requested review from fs-eire

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snnn @fs-eire