Flash attention recompute #20603
Merged
Flash attention recompute #20603
+1,002
−381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengwa
added
the
training
guyang3532
reviewed
May 10, 2024
orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc
Show resolved
Hide resolved
guyang3532
reviewed
May 10, 2024
orttraining/orttraining/core/optimizer/memory_optimizer/memory_insight.cc
Outdated
Show resolved
Hide resolved
…pengwa/flash_attn_recompute
guyang3532
reviewed
May 11, 2024
orttraining/orttraining/core/optimizer/memory_optimizer/memory_optimizer.cc
Outdated
Show resolved
Hide resolved
guyang3532
reviewed
May 11, 2024
orttraining/orttraining/core/optimizer/memory_optimizer/recompute_analysis.cc
Show resolved
Hide resolved
guyang3532
previously approved these changes
May 13, 2024
zhijxu-MS
reviewed
May 13, 2024
zhijxu-MS
reviewed
May 13, 2024
orttraining/orttraining/core/optimizer/memory_optimizer/memory_optimizer.cc
Show resolved
Hide resolved
…pengwa/flash_attn_recompute
wschin
approved these changes
May 21, 2024
…pengwa/flash_attn_recompute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash attn recompute
Better Memory Efficiency
Customer model can run both PyTorch SPDA and Flash Attn, this PR make it possible to let the Flash Attn path work with ORTModule layerwise recompute. The peak drop from 45.xGB to 32.xGB if we only compare the layers (not including other pieces, BTW there are few more optimization targeting other pieces as well later).
Better Perf
Using Flash ATTN bring additionally 16% end to end time reduction, with highly aligned loss curve.
Use JSON File to pass Recompute Plans
To overcome the limitation of max length of the strings defined in session options.
Motivation and Context