Improve C# documentation #1154
Draft
Improve C# documentation #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyline75489
commented
Dec 18, 2024
| @@ -18,7 +21,7 @@ private Images(IntPtr imagesHandle) | |||
|
|
|||
| internal IntPtr Handle { get { return _imagesHandle; } } | |||
|
|
|||
| public static Images Load(string[] imagePaths) | |||
There was a problem hiding this comment.
This is bothering me. Why do we use a static method Images.Load() instead of new Images(string[] imagePaths) just like in java:
skyline75489
commented
Dec 18, 2024
| /// <summary> | ||
| /// Wraps some utility functions that are available globally | ||
| /// <summary> | ||
| internal class Utils |
There was a problem hiding this comment.
In Java there's a GenAI class that handles the global configurations:
Should we do the same in C#?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing C# documentation according to the Javadoc (#1136).
Internal work item: https://task.ms/aii/53908