Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug Pipelines #1116

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add Debug Pipelines #1116

wants to merge 17 commits into from

Conversation

aciddelgado
Copy link
Contributor

Issues with asserts were previously missed because all pipelines ran in Release mode. This PR adds Debug pipelines.

@aciddelgado aciddelgado requested a review from a team as a code owner December 3, 2024 22:51
@baijumeswani
Copy link
Collaborator

Do we need both Release and Debug? Can we instead convert the existing pipelines to build Debug?

@natke natke self-requested a review December 4, 2024 01:02
@natke
Copy link
Contributor

natke commented Dec 4, 2024

Do we need both Release and Debug? Can we instead convert the existing pipelines to build Debug?

We may not need both for every PR, but we will definitely want to the pipelines in Release mode and ensure they are successful before doing a release

@skyline75489
Copy link
Contributor

So... I was thinking maybe we should remove presets once and for all? Using presets is causing the switch between Debug and Release even more difficult. It also causes the build time to be doubled for Java as I mentioned in the group chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants