Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to other exported types in typedefs #268

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

jasongin
Copy link
Member

Fixes: #267

  • Omit the namespace when referencing other exported types in a module. Types tagged with [JSExport] are un-namesapced in JS, even if they are namespaced in .NET.
  • Use the "export name" when referencing other exported types in a module. That is the optional name override in the [JSExport("name")] attribute. It defaults to the regular type name.
  • Add a reference to another exported, namespaced type in the test Module.cs file. The generated type-definitions for those types will be checked by the TS compiler as part of the project test cases.

@jasongin jasongin merged commit 947f4c1 into main Apr 10, 2024
24 checks passed
@jasongin jasongin deleted the dev/jasongin/jsexport-name branch April 10, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong typecript namespaces with class composition
2 participants