Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Text.Json.JsonElement
which is a struct with an indexed property that returns (another)JsonElement
. This caused a stack overflow: Struct property with circular reference can cause stack-overflow in JS marshalling expression builder #181. Skipping indexed properties is correct anyway and is a convenient way to avoid the crash for now, though structs with non-indexed self-referential properties may still trigger it. (I have not found any yet.)ReadOnlyMemory<T>
, only when the memory was originally allocated by a JS typed array. SK added some APIs that referencedReadOnlyMemory<T>
and that was causing an exception due to indirect references toSpan<T>
(which isn't supported and is normally skipped by the marshaller). Adding this special handling forReadOnlyMemory<T>
resolves the issue.