Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass args to TS generator tool using response file #178

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Pass args to TS generator tool using response file #178

merged 2 commits into from
Nov 11, 2023

Conversation

jasongin
Copy link
Member

Fixes #148

  • When parsing args for the TS generator, read args from a response file indicated by a @ prefix.
  • Update the generator .targets file to pass all arguments via a response file, to avoid exceeding the limit on length of command-line.
  • Refactor the debug-attach helper code to a separate class so it can be used by the source-generator and typedefs-generator tools. (It was useful for debugging the response-file parsing code.)

@jasongin jasongin requested a review from vmoroz November 11, 2023 00:12
@jasongin jasongin merged commit 1ceb048 into main Nov 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoroz vmoroz vmoroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a response file to pass long arguments list to the typedefs generator tool
2 participants
@jasongin @vmoroz