Add benchmarks, GC handle tracking test #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_create_platform
(to support--enable-gc
option)TryGetValueExternal()
API, which returnsnull
if the value is not an external. This fixes a bug in marshalling that arose when constructing aManagedHost
instance for benchmarks.I added GC handle tracking because I was struggling with GC pressure during the many iterations that BenchmarkDotNet likes to run. First I thought there was a leak, but the test confirmed there is not. The problem is just that BenchmarkDotNet can run millions of iterations, which may each allocate and release objects, and JS GC does not keep up, so successive iterations get gradually slower. I couldn't figure out a way to explicitly run the JS GC during tests without distorting the benchmark results. (The test runner carefully manages the .NET GC, but doesn't know anything about JS.) So the workaround for now is to reduce the number of iterations.