Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest SK and fix issues #155

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Update to latest SK and fix issues #155

merged 9 commits into from
Sep 25, 2023

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented Sep 23, 2023

Fixes #151

  • Fix a bug in the dynamic type exporter that caused it to skip exporting parameter types referenced by interface methods.
  • Automatically switch to the JS thread when calling form .NET to a JS interface method.
  • Emit stubs for add_ and remove_ event methods when dynamically generating a JS proxy for an interface. Events are still not yet supported, but this fix prevents events on an interface from blocking other members of the interface from being used.
  • Include base interfaces (extends clause) when generating interface type definitions.
  • Fix doc-comment lookup for generic methods when generating type definitions.
  • Update the example to Semantic version 0.24.
    • It has been a while since the last update, so there were several API changes that required updating the example.js code.
    • It has a new way of dynamically loading the PromptTemplateEngine assembly which requires a minor workaround. That took me a while to figure out why the input string wasn't getting incorporated in the request: because when that assembly was not loaded the null prompt engine ignored the input.

@jasongin jasongin merged commit 9ab1030 into main Sep 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger creation in Semantic Kernel sample not working
2 participants