Include inner message in exception thrown from JS thread (#378)

microsoft · Sep 17, 2024 · 2b7785b · 2b7785b
1 parent 0056dbd
commit 2b7785b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/NodeApi/JSException.cs b/src/NodeApi/JSException.cs
@@ -43,7 +43,7 @@ public JSException(JSError error) : base(error.Message)
     /// This constructor must be called while still on the JS thread.
     /// </remarks>
     internal JSException(Exception innerException)
-        : this("Exception thrown from JS thread. See inner exception for details.", innerException)
+        : this("Exception thrown from JS thread: " + innerException?.Message, innerException)
     {
         JSException? innerJSException = innerException as JSException;
         JSValue? jsError = innerJSException?.Error?.Value;

diff --git a/test/NodejsEmbeddingTests.cs b/test/NodejsEmbeddingTests.cs
@@ -214,7 +214,7 @@ public void ErrorPropagation()
             });
         });
 
-        Assert.StartsWith("Exception thrown from JS thread.", exception.Message);
+        Assert.Equal("Exception thrown from JS thread: test", exception.Message);
         Assert.IsType<JSException>(exception.InnerException);
 
         exception = (JSException)exception.InnerException;