Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for numeric regular expressions; some bug fixes #61

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add tests for numeric regular expressions; some bug fixes #61

merged 2 commits into from
Nov 21, 2024

Conversation

hudson-ai
Copy link
Collaborator

Ports the numeric range tests we're currently doing in python into the crate. Found some bugs and fixed them.

mmoskal
mmoskal approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mmoskal mmoskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needed, there is rstest crate which lets you do fixtures and cases. Never used it yet though.

@hudson-ai
Copy link
Collaborator Author

If needed, there is rstest crate which lets you do fixtures and cases. Never used it yet though.

Cool, may very well look into it!

@hudson-ai hudson-ai merged commit 5c0705a into microsoft:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoskal mmoskal mmoskal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hudson-ai @mmoskal