Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dual ESM/CJS support, tsconfig module now Node16, improved pnpm support #791

Merged
merged 38 commits into from
Aug 13, 2024

Conversation

huntj88
Copy link
Contributor

@huntj88 huntj88 commented Aug 7, 2024

  • Update Module and ModuleResolution to Node16 in tsconfig.
    • This is what FluidFramework is doing for their default tsconfig's
    • FF expects that all customers update TS configuration to use Node16+ compatible resolution.
      • example: "module": "Node16" + "moduleResolution": "Node16"
      • For apps, they often want "module": "ESNext" + "moduleResolution": "Bundler"
  • Add .js extensions throughout code.
  • export package.json override on CJS builds for {type: commonjs}
  • Added resolution support for @microsoft/live-share/internal for Node10.
    • ESM only for Node10, CJS not supported. This matches FF.
  • update live-share-acs, live-share-canvas, live-share-react to ship CJS and ESM builds.
  • update live-share index to not have a root index, just index.public.ts and index.internal.ts
  • updated dependencies and peerDependencies.
  • Added a pnpm project, and a CI check to ensure that Live Share works and is simple to use with pnpm
image

@huntj88 huntj88 changed the base branch from mainv2 to jameshunt/presence-with-audience-state August 7, 2024 19:36
@huntj88 huntj88 changed the title Module: Node16 Better dual ESM/CJS support, change tsconfig module to Node 16 Aug 7, 2024
@huntj88 huntj88 marked this pull request as ready for review August 7, 2024 21:17
@huntj88 huntj88 changed the title Better dual ESM/CJS support, change tsconfig module to Node 16 Better dual ESM/CJS support, tsconfig module now Node16, improved pnpm support Aug 9, 2024
Copy link
Contributor

@ryanbliss ryanbliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from jameshunt/presence-with-audience-state to mainv2 August 13, 2024 20:33
@huntj88 huntj88 merged commit 217519d into mainv2 Aug 13, 2024
7 checks passed
@huntj88 huntj88 deleted the jameshunt/more-cleanup branch August 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants