Feature: show plugins and clients in panel #5784
Open
+386
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/microsoft/kiota into task/extension/show-plugins-and-clients-in-panel
Signed-off-by: Vincent Biret <[email protected]>
baywet
requested changes
Nov 21, 2024
| } | ||
|
|
||
| private async deletePlugin(pluginName: string): Promise<KiotaLogEntry[] | undefined> { | ||
| const result = await vscode.window.withProgress({ |
There was a problem hiding this comment.
lots of duplication between the two methods, I think we have an opportunity to refactor and reduce duplication here.
| } | ||
| return element; | ||
| } | ||
|
|
||
| public loadWorkspaceContent(): void { |
There was a problem hiding this comment.
I believe we're mixing concerns here, and reducing testability in the process.
The tree view providers are responsible for managing the state of the tree view, not for getting the data in the first place. I think we should split things here.
There was a problem hiding this comment.
This makes sense. I've separated these concerns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #5715
Demo
Tasks
Clientscomponent when there is at least 1 client in the current context. If no client was found, the node shouldn't be displayed.Pluginscomponent when there is at least 1 plugin in the current context. If no plugin was found, the node shouldn't be displayed.ClientsandPluginscomponents must to be expandable/collapsible.{ }icon in any existing plugin/client, we should show the textSelect. When clicking on it, the API Explorer should be loaded with the right client/plugin and right selected paths (same as theEditPathscodelense action)Delete. When clicking on it for any existing plugin/client, the plugin remove should be performed.Future work