Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove handlers without code changes #316

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented Feb 20, 2024

Motivation and Context (Why the change? What's the scenario?)

The current KM Service definition requires editing and rebuilding code/images in order to add/remove pipeline handlers.
This PR allows to add/remove handlers simply by editing the configuration files, providing the required assembly without the need to rebuild.

High level description (Approach, Design)

  • Remove from KM Builder the hardcoded list of handlers used for the service. The list remains only for the serverless option.
  • Add to service configuration the list of handlers to load.
  • Us reflection to load handlers from assemblies.

@dluc dluc merged commit 58ce8c3 into microsoft:main Feb 20, 2024
2 checks passed
@dluc dluc deleted the handlers branch February 20, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant