Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OpenCensus with OpenTelemetry #2136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace OpenCensus with OpenTelemetry #2136

wants to merge 2 commits into from

Commits on May 7, 2024

  1. Replace OpenCensus with OpenTelemetry 

    The OpenCensus repo has been archived on July 31, 2023 (see [1]),
and thus will receive no further updates. OTel offers a bridge to
help transition however this means every project using hcsshim
need to set up that bridge. At this point, it seems better to
transition to OTel instead.

This commit fully replaces OpenCensus with OpenTelemetry v1.21.

- Package `internal/oc` has been replaced by `internal/otelutil`.
- `octtrpc` has been replaced by `otelttrpc`.
- `go.opencensus.io/plugin/ocgrpc` has been replaced by `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`.
- Whenever possible, span attributes are passed directly when the
span is created.

[1]: https://opentelemetry.io/blog/2023/sunsetting-opencensus/

Signed-off-by: Albin Kerouanton <[email protected]>
    @akerouanton
    akerouanton committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8ba72c4 View commit details
    Browse the repository at this point in the history

  2. Add missing span.End() 

    Previous commit made clear that `(*externalProcess).Wait()` was
missing a call to `span.End()`.

Signed-off-by: Albin Kerouanton <[email protected]>
    @akerouanton
    akerouanton committed May 7, 2024
    Configuration menu
    Copy the full SHA
    136345a View commit details
    Browse the repository at this point in the history