Avoid deadlock in Close() #72
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A call to listenerRoutine while closing can result in a deadlock. The cause appears to be listenerRoutine not giving up when faced with an error of type ERROR_OPERATION_ABORTED. The change adds a case to specifically handle this error type and bubble up ErrFileClosed to listenerRoutine, causing it to terminate gracefully.
|
This change looks straight-forward, and good. Hopefully it gets integrated soon. |
|
This change has been sitting around a while. Any feedback? |
|
Any news? @helsaawy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to listenerRoutine while closing can result in a deadlock. The
cause appears to be listenerRoutine not giving up when faced with an
error of type ERROR_OPERATION_ABORTED.
The change adds a case to specifically handle this error type and bubble
up ErrFileClosed to listenerRoutine, causing it to terminate gracefully.