Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module to github.com/microsoft/go-winio #314

Closed
wants to merge 1 commit into from

Conversation

bouk
Copy link

@bouk bouk commented Feb 9, 2024

The Microsoft GitHub organization uses a lowercase 'm', which other go modules from Microsoft also use. This module using an uppercase M can cause problems in certain build systems when using macOS which uses a case-insensitive file system by default: NixOS/nixpkgs#273998

The Microsoft GitHub organization uses a lowercase 'm', which other go modules from Microsoft also use. This module using an uppercase M can cause problems in certain build systems when using macOS which uses a case-insensitive build system by default: NixOS/nixpkgs#273998

Signed-off-by: Bouke van der Bijl <[email protected]>
@bouk
Copy link
Author

bouk commented Feb 23, 2024

@helsaawy I was wondering if you could take a look at this?

@helsaawy
Copy link
Contributor

@helsaawy I was wondering if you could take a look at this?

I believe renaming the module here will impact anyone who imports it, which is a fairly large and breaking change, as evidenced by the CI failures

@helsaawy
Copy link
Contributor

Duplicate of PR #159

@helsaawy helsaawy closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants