Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Close hvsock handle on listen error; fix tests #310

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

helsaawy
Copy link
Contributor

Close the socket created in
github.com/Microsoft/go-winio/pkg/ListenHvsock if either the Bind or Listen calls fail.

Go changed filepath.VolumeName code, resulting in different behavior in github.com/Microsoft/go-winio/pkg/fs.GetFileSystemType. Update test accordingly.
Also add more debug logs to pkg\fs\resolve_test.go.

Also, move add skip for fuzzing on WS2019 or older to FuzzHvSockRxTx code directly, instead of in ci.yml.

See: https://go-review.googlesource.com/c/go/+/540277

Close the socket created in
`github.com/Microsoft/go-winio/pkg/ListenHvsock` if either the `Bind` or
`Listen` calls fail.

Go changed `filepath.VolumeName` code, resulting in different behavior in
`github.com/Microsoft/go-winio/pkg/fs.GetFileSystemType`.
Update test accordingly.
Also add more debug logs to `pkg\fs\resolve_test.go`.

Also, move add skip for fuzzing on WS2019 or older to `FuzzHvSockRxTx`
code directly, instead of in ci.yml.

See: https://go-review.googlesource.com/c/go/+/540277

Signed-off-by: Hamza El-Saawy <[email protected]>
@helsaawy helsaawy requested a review from a team as a code owner December 11, 2023 22:38
Signed-off-by: Hamza El-Saawy <[email protected]>
@helsaawy helsaawy merged commit bc421d9 into microsoft:main Dec 18, 2023
8 checks passed
@helsaawy helsaawy deleted the hvsock-close branch December 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants