chore: migrate to eslint v9 #33527
Draft
chore: migrate to eslint v9 #33527
+2,069
−1,808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Dec 30, 2024
| @@ -4,7 +4,7 @@ | |||
| "rules": { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Left top edge.chromium.png | 1949 | Changed |
| Callout.Right top edge.chromium.png | 1127 | Changed |
| Callout.Top left edge.chromium.png | 2307 | Changed |
| Callout.Right bottom edge.chromium.png | 3005 | Changed |
| Callout.Top right edge.chromium.png | 1594 | Changed |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Dec 30, 2024
| @@ -4,7 +4,7 @@ | |||
| "rules": { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 6 | Changed |
| Avatar Converged.badgeMask.chromium.png | 21 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full.chromium.png | 3276 | Changed |
| Drawer.Full Overlay RTL.chromium.png | 1167 | Changed |
mainframev
force-pushed
the
eslint-v9-with-flag
branch
3 times, most recently
from
c6b91dd to
a8bd13f
Compare
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
eslint-v9-with-flag
branch
from
9701860 to
cc6f3e3
Compare
mainframev
force-pushed
the
eslint-v9-with-flag
branch
from
cc6f3e3 to
c71d536
Compare
|
Pull request demo site: URL |
mainframev
force-pushed
the
eslint-v9-with-flag
branch
from
ac759c5 to
889a93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to ESLint v9 but sticking with the legacy config format for now. Jumping straight to the new flat format is too much all at once. The plan is to first update ESLint with legacy flag and all related plugins to make sure everything works. After that, will start moving our .eslintrc files over to eslint.config.js and switch to the new flat format.
A lof of changes coming from removal of eslint-plugin-deprecation (it's archived now) and as noted here, now we should use @typescript-eslint/no-deprecated.
In follow-up internal
eslint-pluginwill be moved to flat config,eslint-plugin-react-componentswill be compatible with both v8 and v9.Previous Behavior
New Behavior
Related Issue(s)