-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to nx 19.8 #32923
Merged
Merged
chore: migrate to nx 19.8 #32923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Sep 26, 2024
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 34 | 39 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 664 | 625 | 5000 | |
Button | mount | 305 | 300 | 5000 | |
Field | mount | 1120 | 1137 | 5000 | |
FluentProvider | mount | 715 | 709 | 5000 | |
FluentProviderWithTheme | mount | 88 | 92 | 10 | |
FluentProviderWithTheme | virtual-rerender | 34 | 39 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 77 | 10 | |
MakeStyles | mount | 894 | 887 | 50000 | |
Persona | mount | 1773 | 1753 | 5000 | |
SpinButton | mount | 1397 | 1396 | 5000 | |
SwatchPicker | mount | 1702 | 1681 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
AccordionMinimalPerf.default | 83 | 90 | 0.92:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
FormMinimalPerf.default | 243 | 210 | 1.16:1 |
FlexMinimalPerf.default | 172 | 152 | 1.13:1 |
ChatDuplicateMessagesPerf.default | 166 | 152 | 1.09:1 |
DropdownManyItemsPerf.default | 415 | 383 | 1.08:1 |
ImageMinimalPerf.default | 244 | 225 | 1.08:1 |
GridMinimalPerf.default | 199 | 186 | 1.07:1 |
ButtonMinimalPerf.default | 94 | 89 | 1.06:1 |
ProviderMinimalPerf.default | 211 | 200 | 1.06:1 |
BoxMinimalPerf.default | 208 | 199 | 1.05:1 |
ListCommonPerf.default | 392 | 375 | 1.05:1 |
AvatarMinimalPerf.default | 112 | 108 | 1.04:1 |
CarouselMinimalPerf.default | 263 | 252 | 1.04:1 |
LoaderMinimalPerf.default | 200 | 192 | 1.04:1 |
TextMinimalPerf.default | 202 | 195 | 1.04:1 |
TextAreaMinimalPerf.default | 290 | 280 | 1.04:1 |
HeaderSlotsPerf.default | 475 | 462 | 1.03:1 |
RadioGroupMinimalPerf.default | 270 | 262 | 1.03:1 |
RefMinimalPerf.default | 114 | 111 | 1.03:1 |
AnimationMinimalPerf.default | 302 | 297 | 1.02:1 |
CardMinimalPerf.default | 322 | 315 | 1.02:1 |
ChatWithPopoverPerf.default | 205 | 201 | 1.02:1 |
DatepickerMinimalPerf.default | 3822 | 3743 | 1.02:1 |
EmbedMinimalPerf.default | 1913 | 1871 | 1.02:1 |
ItemLayoutMinimalPerf.default | 718 | 703 | 1.02:1 |
ListMinimalPerf.default | 313 | 306 | 1.02:1 |
MenuMinimalPerf.default | 509 | 497 | 1.02:1 |
PortalMinimalPerf.default | 87 | 85 | 1.02:1 |
SkeletonMinimalPerf.default | 205 | 200 | 1.02:1 |
TableManyItemsPerf.default | 1114 | 1088 | 1.02:1 |
CustomToolbarPrototype.default | 1510 | 1483 | 1.02:1 |
AttachmentSlotsPerf.default | 653 | 646 | 1.01:1 |
CheckboxMinimalPerf.default | 1137 | 1130 | 1.01:1 |
DividerMinimalPerf.default | 212 | 210 | 1.01:1 |
LayoutMinimalPerf.default | 204 | 201 | 1.01:1 |
SliderMinimalPerf.default | 746 | 738 | 1.01:1 |
IconMinimalPerf.default | 403 | 399 | 1.01:1 |
TableMinimalPerf.default | 234 | 232 | 1.01:1 |
ButtonOverridesMissPerf.default | 658 | 659 | 1:1 |
ChatMinimalPerf.default | 442 | 441 | 1:1 |
DropdownMinimalPerf.default | 1414 | 1413 | 1:1 |
HeaderMinimalPerf.default | 210 | 211 | 1:1 |
LabelMinimalPerf.default | 219 | 220 | 1:1 |
MenuButtonMinimalPerf.default | 967 | 964 | 1:1 |
RosterPerf.default | 1613 | 1612 | 1:1 |
PopupMinimalPerf.default | 355 | 354 | 1:1 |
ProviderMergeThemesPerf.default | 653 | 654 | 1:1 |
SegmentMinimalPerf.default | 202 | 201 | 1:1 |
StatusMinimalPerf.default | 404 | 406 | 1:1 |
TreeWith60ListItems.default | 91 | 91 | 1:1 |
AlertMinimalPerf.default | 153 | 154 | 0.99:1 |
InputMinimalPerf.default | 540 | 544 | 0.99:1 |
ListNestedPerf.default | 320 | 323 | 0.99:1 |
ToolbarMinimalPerf.default | 546 | 553 | 0.99:1 |
TreeMinimalPerf.default | 492 | 498 | 0.99:1 |
VideoMinimalPerf.default | 440 | 443 | 0.99:1 |
SplitButtonMinimalPerf.default | 2239 | 2280 | 0.98:1 |
TooltipMinimalPerf.default | 1277 | 1309 | 0.98:1 |
ButtonSlotsPerf.default | 305 | 315 | 0.97:1 |
DialogMinimalPerf.default | 435 | 450 | 0.97:1 |
ListWith60ListItems.default | 380 | 394 | 0.96:1 |
AttachmentMinimalPerf.default | 78 | 83 | 0.94:1 |
ReactionMinimalPerf.default | 211 | 224 | 0.94:1 |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Sep 26, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 640 | 633 | 5000 | |
Breadcrumb | mount | 1682 | 1738 | 1000 | |
Checkbox | mount | 1758 | 1689 | 5000 | |
CheckboxBase | mount | 1493 | 1451 | 5000 | |
ChoiceGroup | mount | 3019 | 3028 | 5000 | |
ComboBox | mount | 683 | 691 | 1000 | |
CommandBar | mount | 6580 | 6612 | 1000 | |
ContextualMenu | mount | 12082 | 11985 | 1000 | |
DefaultButton | mount | 805 | 793 | 5000 | |
DetailsRow | mount | 2226 | 2169 | 5000 | |
DetailsRowFast | mount | 2274 | 2245 | 5000 | |
DetailsRowNoStyles | mount | 2070 | 2110 | 5000 | |
Dialog | mount | 2706 | 2869 | 1000 | |
DocumentCardTitle | mount | 226 | 223 | 1000 | |
Dropdown | mount | 1986 | 1970 | 5000 | |
FocusTrapZone | mount | 1147 | 1168 | 5000 | |
FocusZone | mount | 1081 | 1111 | 5000 | |
GroupedList | mount | 42398 | 42626 | 2 | |
GroupedList | virtual-rerender | 20245 | 20567 | 2 | |
GroupedList | virtual-rerender-with-unmount | 52019 | 52368 | 2 | |
GroupedListV2 | mount | 255 | 232 | 2 | |
GroupedListV2 | virtual-rerender | 210 | 219 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 221 | 239 | 2 | |
IconButton | mount | 1144 | 1144 | 5000 | |
Label | mount | 336 | 349 | 5000 | |
Layer | mount | 2738 | 2794 | 5000 | |
Link | mount | 389 | 394 | 5000 | |
MenuButton | mount | 969 | 1009 | 5000 | |
MessageBar | mount | 21643 | 21518 | 5000 | |
Nav | mount | 2058 | 2035 | 1000 | |
OverflowSet | mount | 770 | 785 | 5000 | |
Panel | mount | 1803 | 1845 | 1000 | |
Persona | mount | 752 | 743 | 1000 | |
Pivot | mount | 913 | 916 | 1000 | |
PrimaryButton | mount | 935 | 947 | 5000 | |
Rating | mount | 4753 | 4714 | 5000 | |
SearchBox | mount | 941 | 940 | 5000 | |
Shimmer | mount | 1943 | 1888 | 5000 | |
Slider | mount | 1366 | 1330 | 5000 | |
SpinButton | mount | 2937 | 3002 | 5000 | |
Spinner | mount | 401 | 397 | 5000 | |
SplitButton | mount | 1909 | 1863 | 5000 | |
Stack | mount | 431 | 417 | 5000 | |
StackWithIntrinsicChildren | mount | 881 | 887 | 5000 | |
StackWithTextChildren | mount | 2763 | 2810 | 5000 | |
SwatchColorPicker | mount | 6485 | 6387 | 5000 | |
TagPicker | mount | 1475 | 1473 | 5000 | |
Text | mount | 401 | 386 | 5000 | |
TextField | mount | 948 | 958 | 5000 | |
ThemeProvider | mount | 873 | 851 | 5000 | |
ThemeProvider | virtual-rerender | 571 | 593 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1295 | 1317 | 5000 | |
Toggle | mount | 622 | 603 | 5000 | |
buttonNative | mount | 197 | 192 | 5000 |
mainframev
approved these changes
Sep 27, 2024
Hotell
force-pushed
the
nx/migrate/19_8
branch
from
October 1, 2024 14:13
f9c4c03
to
8cfae7a
Compare
github-actions
bot
modified the milestones:
September Project Cycle Q3 2024,
October Project Cycle Q4 2024
Oct 1, 2024
mltejera
pushed a commit
to mltejera/office-ui-fabric-react
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
NOTE: after this is merged we will have ts-eslint utils v8 in node_modules (it won't affect us and will be mitigate once we migrate to ts-eslint v8)
Related Issue(s)