Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stories compound-button to divider #32856

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

eljefe223
Copy link
Contributor

Previous Behavior

Stories used old patterns and some arg controls were broken

New Behavior

Fixes arg controls and updates stories to better patterns.
Adds a check to remove object-based attributes from the code sample when reset to null.\

Related Issue(s)

  • Fixes #

@eljefe223 eljefe223 requested a review from a team as a code owner September 17, 2024 21:24
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 17, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 17, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@eljefe223 eljefe223 force-pushed the users/jes/story-cleanup-2 branch 3 times, most recently from fe32ed4 to 66a8b89 Compare September 23, 2024 17:20
Copy link
Contributor

@davatron5000 davatron5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like one set of options needs updated but pre-approving.

@eljefe223 eljefe223 merged commit 871477e into microsoft:master Sep 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants