-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stories compound-button to divider #32856
Merged
eljefe223
merged 7 commits into
microsoft:master
from
eljefe223:users/jes/story-cleanup-2
Sep 24, 2024
Merged
fix: stories compound-button to divider #32856
eljefe223
merged 7 commits into
microsoft:master
from
eljefe223:users/jes/story-cleanup-2
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
eljefe223
force-pushed
the
users/jes/story-cleanup-2
branch
3 times, most recently
from
September 23, 2024 17:20
fe32ed4
to
66a8b89
Compare
eljefe223
force-pushed
the
users/jes/story-cleanup-2
branch
from
September 24, 2024 15:04
4ec9d8d
to
e2766fd
Compare
eljefe223
commented
Sep 24, 2024
davatron5000
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like one set of options needs updated but pre-approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Stories used old patterns and some arg controls were broken
New Behavior
Fixes arg controls and updates stories to better patterns.
Adds a check to remove object-based attributes from the code sample when reset to null.\
Related Issue(s)