Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade @typescript-eslint to v6 and eslint to v8 #31988

Merged
merged 15 commits into from
Jul 25, 2024
Merged

chore: upgrade @typescript-eslint to v6 and eslint to v8 #31988

merged 15 commits into from
Jul 25, 2024

Conversation

mainframev
Copy link
Contributor

@mainframev mainframev commented Jul 12, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • Upgraded @typescript-eslint to v6 and eslint to v8.
  • Updated related eslint packages
  • Added @typescript-eslint/rule-tester package

api changes:

  • meta.docs.recommended now recommended | stylistic | error instead of error | strict | warn | false
  • @typescript-eslint/utils no longer exports RuleTester
  • CLIEngine removed

Perf bench

yarn lage lint

Before After
10m 6s 10m 20s / 𝚫 +2.3% slowdown

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@mainframev mainframev force-pushed the chore/upgrade-eslint branch from 00e45df to d652322 Compare July 12, 2024 18:56
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 35 40 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 644 645 5000
Button mount 308 313 5000
Field mount 1177 1139 5000
FluentProvider mount 717 725 5000
FluentProviderWithTheme mount 83 84 10
FluentProviderWithTheme virtual-rerender 35 40 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 73 83 10
MakeStyles mount 876 875 50000
Persona mount 1812 1759 5000
SpinButton mount 1399 1387 5000
SwatchPicker mount 1665 1677 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 168 133 1.26:1
TreeWith60ListItems.default 96 84 1.14:1
ProviderMinimalPerf.default 220 197 1.12:1
AlertMinimalPerf.default 164 148 1.11:1
PortalMinimalPerf.default 92 83 1.11:1
AccordionMinimalPerf.default 86 78 1.1:1
CardMinimalPerf.default 336 311 1.08:1
BoxMinimalPerf.default 201 188 1.07:1
ButtonMinimalPerf.default 90 84 1.07:1
FlexMinimalPerf.default 161 151 1.07:1
LoaderMinimalPerf.default 200 187 1.07:1
AttachmentMinimalPerf.default 85 80 1.06:1
AvatarMinimalPerf.default 110 104 1.06:1
DividerMinimalPerf.default 207 196 1.06:1
IconMinimalPerf.default 419 397 1.06:1
VideoMinimalPerf.default 438 412 1.06:1
InputMinimalPerf.default 561 533 1.05:1
ReactionMinimalPerf.default 218 208 1.05:1
TextAreaMinimalPerf.default 301 286 1.05:1
TreeMinimalPerf.default 493 468 1.05:1
DialogMinimalPerf.default 447 431 1.04:1
MenuMinimalPerf.default 518 500 1.04:1
StatusMinimalPerf.default 399 385 1.04:1
TooltipMinimalPerf.default 1280 1228 1.04:1
GridMinimalPerf.default 197 191 1.03:1
LayoutMinimalPerf.default 202 196 1.03:1
ListCommonPerf.default 384 372 1.03:1
SkeletonMinimalPerf.default 205 199 1.03:1
SliderMinimalPerf.default 771 750 1.03:1
TableManyItemsPerf.default 1113 1082 1.03:1
TextMinimalPerf.default 200 195 1.03:1
AnimationMinimalPerf.default 298 293 1.02:1
ChatWithPopoverPerf.default 203 199 1.02:1
FormMinimalPerf.default 215 210 1.02:1
ImageMinimalPerf.default 226 221 1.02:1
PopupMinimalPerf.default 351 345 1.02:1
ProviderMergeThemesPerf.default 662 651 1.02:1
RadioGroupMinimalPerf.default 271 265 1.02:1
TableMinimalPerf.default 238 233 1.02:1
CheckboxMinimalPerf.default 1126 1113 1.01:1
DropdownMinimalPerf.default 1430 1422 1.01:1
CustomToolbarPrototype.default 1469 1450 1.01:1
ToolbarMinimalPerf.default 541 536 1.01:1
AttachmentSlotsPerf.default 633 630 1:1
ChatMinimalPerf.default 436 436 1:1
DatepickerMinimalPerf.default 3495 3506 1:1
HeaderSlotsPerf.default 477 478 1:1
ListMinimalPerf.default 310 310 1:1
ListNestedPerf.default 334 335 1:1
SegmentMinimalPerf.default 194 194 1:1
SplitButtonMinimalPerf.default 2228 2230 1:1
DropdownManyItemsPerf.default 384 389 0.99:1
EmbedMinimalPerf.default 1846 1859 0.99:1
HeaderMinimalPerf.default 209 211 0.99:1
ItemLayoutMinimalPerf.default 696 704 0.99:1
RosterPerf.default 1568 1576 0.99:1
ButtonSlotsPerf.default 322 327 0.98:1
MenuButtonMinimalPerf.default 936 954 0.98:1
ButtonOverridesMissPerf.default 662 685 0.97:1
LabelMinimalPerf.default 212 218 0.97:1
ListWith60ListItems.default 370 382 0.97:1
RefMinimalPerf.default 106 109 0.97:1
CarouselMinimalPerf.default 256 270 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 634 5000
Breadcrumb mount 1697 1661 1000
Checkbox mount 1699 1681 5000
CheckboxBase mount 1483 1489 5000
ChoiceGroup mount 3051 3011 5000
ComboBox mount 687 687 1000
CommandBar mount 6636 6663 1000
ContextualMenu mount 12253 12578 1000
DefaultButton mount 805 790 5000
DetailsRow mount 2236 2239 5000
DetailsRowFast mount 2232 2308 5000
DetailsRowNoStyles mount 2052 2050 5000
Dialog mount 2696 2726 1000
DocumentCardTitle mount 224 232 1000
Dropdown mount 2033 2016 5000
FocusTrapZone mount 1139 1129 5000
FocusZone mount 1058 1080 5000
GroupedList mount 42684 42845 2
GroupedList virtual-rerender 20392 20356 2
GroupedList virtual-rerender-with-unmount 52068 51473 2
GroupedListV2 mount 222 232 2
GroupedListV2 virtual-rerender 224 214 2
GroupedListV2 virtual-rerender-with-unmount 235 228 2
IconButton mount 1138 1126 5000
Label mount 337 349 5000
Layer mount 2746 2763 5000
Link mount 391 400 5000
MenuButton mount 988 998 5000
MessageBar mount 21304 21281 5000
Nav mount 2047 1997 1000
OverflowSet mount 772 804 5000
Panel mount 1872 1862 1000
Persona mount 767 772 1000
Pivot mount 914 899 1000
PrimaryButton mount 938 929 5000
Rating mount 4742 4749 5000
SearchBox mount 925 964 5000
Shimmer mount 1960 1907 5000
Slider mount 1314 1359 5000
SpinButton mount 3001 2868 5000
Spinner mount 388 397 5000
SplitButton mount 1903 1900 5000
Stack mount 425 422 5000
StackWithIntrinsicChildren mount 892 885 5000
StackWithTextChildren mount 2796 2813 5000
SwatchColorPicker mount 6433 6470 5000
TagPicker mount 1518 1473 5000
Text mount 394 375 5000
TextField mount 948 967 5000
ThemeProvider mount 862 851 5000
ThemeProvider virtual-rerender 593 586 5000
ThemeProvider virtual-rerender-with-unmount 1305 1299 5000
Toggle mount 638 598 5000
buttonNative mount 194 194 5000

@mainframev mainframev self-assigned this Jul 12, 2024
@mainframev mainframev force-pushed the chore/upgrade-eslint branch 2 times, most recently from 41c2f9d to 688c8ea Compare July 14, 2024 19:39
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 14, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@mainframev mainframev force-pushed the chore/upgrade-eslint branch 4 times, most recently from 0efbb27 to 49fa4b7 Compare July 19, 2024 09:37
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 19, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@mainframev mainframev force-pushed the chore/upgrade-eslint branch 2 times, most recently from 28afc3a to 6f4eed7 Compare July 19, 2024 19:08
@mainframev mainframev force-pushed the chore/upgrade-eslint branch 3 times, most recently from 5e6a002 to bd2985c Compare July 22, 2024 10:44
@mainframev mainframev force-pushed the chore/upgrade-eslint branch from a24a80e to 10f20fb Compare July 23, 2024 15:42
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 23, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@mainframev mainframev requested a review from Hotell July 23, 2024 16:36
@mainframev mainframev force-pushed the chore/upgrade-eslint branch from 10f20fb to 81a783f Compare July 24, 2024 09:25
Hotell
Hotell reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more things to address and we are good to go!

ty

@mainframev mainframev force-pushed the chore/upgrade-eslint branch from 81a783f to 44b3c14 Compare July 25, 2024 10:55
Hotell
Hotell approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job !

LGTM

@Hotell Hotell removed the request for review from a team July 25, 2024 12:28
@mainframev mainframev merged commit 1eb29be into microsoft:master Jul 25, 2024
23 checks passed
@Hotell Hotell mentioned this pull request Jul 25, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@chrisdholt chrisdholt chrisdholt left review comments

@bsunderhus bsunderhus bsunderhus left review comments

@Hotell Hotell Hotell approved these changes

@layershifter layershifter layershifter approved these changes

Assignees

@mainframev mainframev

Labels
Area: Build System CI Package: eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mainframev @fabricteam @Hotell @bsunderhus @chrisdholt @layershifter