docs: Surfacing Dropdown and Combobox prop comments to docsite
#31430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
approved these changes
May 20, 2024
smhigley
approved these changes
May 20, 2024
spmonahan
approved these changes
May 20, 2024
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 617 | 624 | 5000 | |
| Button | mount | 304 | 311 | 5000 | |
| Field | mount | 1144 | 1152 | 5000 | |
| FluentProvider | mount | 697 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 88 | 78 | 10 | |
| MakeStyles | mount | 870 | 866 | 50000 | |
| Persona | mount | 1778 | 1758 | 5000 | |
| SpinButton | mount | 1390 | 1418 | 5000 | |
| SwatchPicker | mount | 1545 | 1557 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 21, 2024
* master: applying package updates applying package updates docs: Surfacing `Dropdown` and `Combobox` prop comments to docsite (microsoft#31430) (web-components) call click in button keydownHandler (microsoft#31428) Modify data and color codes for examples to fix accessibility issues (microsoft#31425) chore(deps): bump semver from 5.7.1 to 6.3.1 (microsoft#31420) applying package updates Improve gauge chart screen reader accessibility (microsoft#26682) applying package updates applying package updates
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The documentation comments of some props in
DropdownandComboboxwere not being correctly surfaced to the docsite.New Behavior
This was happening because some of the comments had
/*instead of/**, which is what indicates the docsite which comments to surface. This PR fixes this issue so that those comments are correctly surfaced now.Related Issue(s)