Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus order issue in legends overflow callout #31317

Merged
merged 2 commits into from May 14, 2024

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented May 9, 2024

Previous Behavior

  • Pressing the up or down arrow keys while at the first or last legend button in the legends overflow callout causes the page to scroll and collapses the list.
  • Pressing the tab or shift-tab keys in the callout doesn't move focus to next or previous interactive element.

New Behavior

  • Navigating with the up or down arrow keys, or using the tab or shift-tab keys in the legends overflow callout, cycles focus through legend buttons.

When the legend overflow button is focused, pressing the enter key opens the callout, and pressing the escape key closes it.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

Copy link

codesandbox-ci bot commented May 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@krkshitij krkshitij marked this pull request as ready for review May 9, 2024 10:05
@krkshitij krkshitij requested a review from a team as a code owner May 9, 2024 10:05
@AtishayMsft
Copy link
Contributor

Mention in the new behavior that the user has to use the enter and escape keys to open and close the overflow control.

@krkshitij krkshitij merged commit aa5c395 into microsoft:master May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants