fix(fluent-button): fix typo in compound disabled selector, add tests #31302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
reviewed
May 7, 2024
packages/web-components/src/anchor-button/anchor-button.spec.ts
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
davatron5000
force-pushed
the
davatron5000/fixSelectorInButtonStyles
branch
from
8337439
to
82f4da1
Compare
chrisdholt
approved these changes
May 7, 2024
There was a problem hiding this comment.
Will leave to @radium-v to sign off and manage with the current merge happening.
radium-v
approved these changes
May 7, 2024
radium-v
force-pushed
the
web-components-v3
branch
from
707be68
to
3ba33e2
Compare
davatron5000
requested review from
a team,
spmonahan,
micahgodbolt,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
davatron5000
force-pushed
the
davatron5000/fixSelectorInButtonStyles
branch
2 times, most recently
from
b839e30
to
25ed614
Compare
radium-v
force-pushed
the
web-components-v3
branch
from
8f49a44
to
cb6fdf3
Compare
davatron5000
force-pushed
the
davatron5000/fixSelectorInButtonStyles
branch
from
25ed614
to
08a1bdd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 14, 2024
change/@fluentui-web-components-f04748f8-f9ea-46fa-a74b-b301279eb3c3.json
Show resolved
Hide resolved
davatron5000
force-pushed
the
davatron5000/fixSelectorInButtonStyles
branch
2 times, most recently
from
a678b15
to
26c500d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
janechu
approved these changes
May 15, 2024
davatron5000
force-pushed
the
davatron5000/fixSelectorInButtonStyles
branch
from
26c500d
to
4b65971
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
chrisdholt
removed request for
spmonahan,
micahgodbolt,
a team,
JustSlone,
jurokapsiar and
tudorpopams
chrisdholt
approved these changes
May 16, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Found a syntax issue in compound disabled CSS selector for
<fluent-button>and<fluent-anchor-button>. No existing behavior because CSS was invalid.New Behavior
Adding the
disabledattribute and thedisabled-focusableattribute to a FluentButton or FluentAnchorButton with[appearance='primary']will have a transparent border.Related Issue(s)